[WEB-28] [EDITOR] implement code blocks #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 30, 2023 18:32
josh-ramos-22
requested review from
hdphuong,
jamest0 and
lauraw0
as code owners
lauraw0
reviewed
Apr 6, 2023
frontend/src/packages/editor/components/buttons/EditorCodeButton.tsx
Outdated
Show resolved
Hide resolved
lauraw0
approved these changes
Apr 6, 2023
Contributor
lauraw0
left a comment
lauraw0
left a comment
There was a problem hiding this comment.
lgtm! pls check comments and then merge whenever 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes required?
Currently, there is no way to style text as
code.Being a society for Computer Science, CSESoc articles will inevitably need to have some integrated
codestyling.Changes
frontend/src/cse-ui-kit/small_buttons/CodeButton.tsx: contains button component used to toggle code styling.frontend/src/cse-ui-kit/assets/code-button.svgfor theCodeButtoncomponentfrontend/src/packages/editor/components/EditorBlock.tsxTextstyled componentfrontend/src/packages/editor/components/buttons/EditorCodeButton.tsx: Defines code button in editor used to toggle code stylingfrontend/src/packages/editor/components/buttons/buttonHelpers.tscodeas a valid text decorationCtrl `as the keyboard shortcut for code style toggling.frontend/src/packages/editor/types.tscodeto the type definition ofCustomTextScreenshots